handle multiple function calls in openai #346
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nly one function call at a time. Fixed this to handle multiple function calls.
jeevan057
changed the title
|
This is awesome. Thank you! @chadbailey59 what do you think? |
|
Great thanks! |
|
any concerns merging this? I'm running into the same error. |
kwindla
requested changes
Sep 30, 2024
src/pipecat/services/openai.py
Outdated
| tool_id_list.append(tool_call_id) | ||
| for function_name,arguments,tool_id in zip(functions_list,arguments_list,tool_id_list): | ||
| if self.has_function(function_name): | ||
| await self._handle_function_call(context, tool_call_id, function_name, arguments) |
There was a problem hiding this comment.
The argument here should be tool_id not tool_call_id.
|
Oof. Enough stuff has changed out from under this PR that there needs to be some more code in the context aggregator to make this work, now. I'll figure this out tonight and post another PR. Thank you for doing the work, here ... we'll get this into the next Pipecat release! |
|
Merged as this PR: #522 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openai can give multiple tool calls
ex : "message": {
"role": "assistant",
"content": null,
"tool_calls": [
{
"id": "call_cuC7cq3IoIqCN2IvwfGuNl8J",
"type": "function",
"function": {
"name": "add_numbers",
"arguments": "{"a": 1, "b": 2}"
}
},
{
"id": "call_SfbHakQINYSeK9a7VzQq50OW",
"type": "function",
"function": {
"name": "add_numbers",
"arguments": "{"a": 3, "b": 4}"
}
}
],
"refusal": null
},
The current implementation assumes only single function call. In this case we get function name as add_numbersadd_numbers (here we have function name twice ). This would fail when the openai is giving multiple tool calls.
The fix I used is create a list of function names and call them.